Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/py datetime #797

Merged
merged 3 commits into from
May 23, 2018
Merged

Fix/py datetime #797

merged 3 commits into from
May 23, 2018

Conversation

jhamman
Copy link
Member

@jhamman jhamman commented May 22, 2018

cc @tbohn

@tbohn
Copy link
Contributor

tbohn commented May 22, 2018

Thanks @jhamman !

@jhamman jhamman requested a review from dgergel May 22, 2018 18:56
@tbohn
Copy link
Contributor

tbohn commented May 22, 2018

Unfortunately, the problem still seems to exist for me. I restarted my previously-failing builds and they still fail with the same error.

@jhamman
Copy link
Member Author

jhamman commented May 22, 2018

My guess is that you haven't tested with this branch then. Make sure your pandas version is 0.23 too!

@tbohn
Copy link
Contributor

tbohn commented May 22, 2018

Doh, sorry, of course, until you check this in, I won't see it. Sorry, not firing on all cylinders at the moment.

@jhamman jhamman merged commit ae67f1d into UW-Hydro:develop May 23, 2018
@jhamman jhamman deleted the fix/py_datetime branch May 23, 2018 15:04
@jhamman jhamman mentioned this pull request May 23, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgergel dgergel Awaiting requested review from dgergel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jhamman @tbohn