Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-active columns being returned from /defs/columns route #193

Closed
jonhusson opened this issue Jun 23, 2017 · 4 comments
Closed

non-active columns being returned from /defs/columns route #193

jonhusson opened this issue Jun 23, 2017 · 4 comments
Labels

Comments

@jonhusson
Copy link
Contributor

example:
https://dev.macrostrat.org/api/v2/defs/columns?project_id=1

returns columns with both 'obsolete' and 'in process' statuses

@jonhusson jonhusson added the bug label Jun 23, 2017
@cambro
Copy link
Member

cambro commented Jun 23, 2017

I believe that this is expected and desirable behavior. This is the defs routes for columns and there would otherwise be no way to access this information. We could add a filter option for status.

@jonhusson
Copy link
Contributor Author

jonhusson commented Jun 23, 2017 via email

@cambro
Copy link
Member

cambro commented Jun 23, 2017

Ah, better to use the columns route for this purpose. That should only return active

@jonhusson
Copy link
Contributor Author

jonhusson commented Jun 23, 2017 via email

@cambro cambro closed this as completed Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants