Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use native travis support for yarn #2860

Merged
merged 4 commits into from
Jan 3, 2017
Merged

use native travis support for yarn #2860

merged 4 commits into from
Jan 3, 2017

Conversation

trevj
Copy link
Contributor

@trevj trevj commented Dec 20, 2016

This change is Reviewable

@trevj
Copy link
Contributor Author

trevj commented Dec 20, 2016

Based on:
https://blog.travis-ci.com/2016-11-21-travis-ci-now-supports-yarn

Thanks for the pointer, @jab!

@trevj trevj requested review from jab and fortuna December 20, 2016 13:48
@jab
Copy link
Contributor

jab commented Dec 20, 2016

Nice @trevj! 👍 👍 👍

@jab
Copy link
Contributor

jab commented Dec 20, 2016

Would we not want to cache node_modules too, as mentioned in the blog post?

cache:
  yarn: true
  directories:
    - node_modules

Copy link
Contributor

@fortuna fortuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!

@jab, I'm not sure it makes sense to cache the node_modules, as they should differ from different runs. Yarn will recreate it from its own cache.

@jab
Copy link
Contributor

jab commented Jan 3, 2017

@fortuna Won't it still help for the requirements that stay the same between runs? That's how it works with a pip (Python installer) directory I have Travis set up to cache in one of my projects, and is also what that blog post @trevj linked to above demonstrates doing, no?

@trevj
Copy link
Contributor Author

trevj commented Jan 3, 2017

I just tried the blog post way with node_modules explicitly called out but honestly it's hard to see a difference - I suspect @fortuna is right to say that since yarn does its own caching and is fast that caching node_modules explicitly probably doesn't make much sense.

I think I'll revert to the simple cache: yarn.

Copy link
Contributor

@jab jab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, looks great! 👍

@trevj trevj merged commit ebec10d into master Jan 3, 2017
@trevj trevj deleted the trevj-yarn-travis branch January 4, 2017 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants