Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'odom' and 'base_link' frames hardcoded #43

Closed
rohbotics opened this issue Feb 17, 2019 · 0 comments
Closed

'odom' and 'base_link' frames hardcoded #43

rohbotics opened this issue Feb 17, 2019 · 0 comments
Assignees
@rohbotics

Comments

@rohbotics
Copy link
Member

I am not entirely sure if this is an actual problem, but the frame names are hard coded in.

This might block UbiquityRobotics/magni_robot#67
@rohbotics rohbotics self-assigned this Feb 17, 2019
rohbotics added a commit that referenced this issue Feb 17, 2019
@rohbotics
Parameterize odom and base frames so that they can be changed
f146378 
Closes: #43

Related to UbiquityRobotics/magni_robot#67
We want to change from base_link to base_footprint
@ghost ghost added in progress and removed ready labels Feb 17, 2019
@rohbotics rohbotics mentioned this issue Feb 17, 2019
Merged
rohbotics added a commit to UbiquityRobotics/magni_robot that referenced this issue Feb 17, 2019
@rohbotics
Use base_footprint in move_basic
edba00b 
Requires: UbiquityRobotics/move_basic#43
rohbotics added a commit to UbiquityRobotics/magni_robot that referenced this issue Feb 17, 2019
@rohbotics
Use base_footprint in move_basic
1fbab05 
Requires: UbiquityRobotics/move_basic#43
@rohbotics rohbotics mentioned this issue Feb 17, 2019
Merged
@jim-v jim-v closed this as completed in #44 Feb 19, 2019
@ghost ghost removed the in review label Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohbotics rohbotics

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rohbotics