Input bindings fixes #191
Merged
Input bindings fixes #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddworak
reviewed
Jun 6, 2018
| nestedInterceptor( | ||
| produceWithNested(options) { case (opts, nested) => | ||
| refreshSelection(opts) | ||
| produce(options) { case opts => |
There was a problem hiding this comment.
Partial function does not seem to be necessary here.
| @@ -32,7 +32,7 @@ object RadioButtons { | |||
| selectedItem: Property[T], options: ReadableProperty[Seq[T]] | |||
There was a problem hiding this comment.
Is there a reason to use ReadableProperty[Seq] here and a SeqProperty in the CheckButtons? We could probably avoid rerendering everything if these were both SeqProperties.
There was a problem hiding this comment.
CheckButtons uses ReadableProperty[Seq] too. I think that produce is good enough here, but we can change the argument type to ReadableSeqProperty to make replacement with repeat backward compatible.
ddworak
approved these changes
Jun 6, 2018
Starzu
force-pushed
the
input-bindings-fixes
branch
from
b997f0b
to
a412a6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to #186