Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid overload for combining SeqProperty elements with another property #462

Merged
merged 10 commits into from
Nov 25, 2019

Conversation

ddworak
Copy link
Member

@ddworak ddworak commented Nov 22, 2019

It was impossible to call ReadableProperty#combine on SeqProperties without explicit type ascription.

@ddworak ddworak added this to the 0.9.0 milestone Nov 22, 2019
@ddworak ddworak changed the base branch from value-changed to master November 22, 2019 08:06
Copy link
Contributor

@mereszeta mereszeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Push Seq type verification to implicits for roSubSeq
# Conflicts:
#	core/src/main/scala/io/udash/properties/seq/ReadableWrapper.scala
@ddworak ddworak merged commit cd393ec into master Nov 25, 2019
@ddworak ddworak deleted the combineElements branch November 25, 2019 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants