-
-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Extra steps and error messages in schema validation #65
Comments
We can close the previous issue and update this one. |
In #43 we added a json schema, which is basically a blueprint for the input template.json file, that validates the template file and we wrote a function that validates the template using python jsonschema library. Both the schema and the error messages need a lot of improvement and that is where this issue comes in.
|
Well detailed breakdown 👍 Reiterating that discussion here as well for reference - I'll share a concept I shared with one of you recently. This comes from Agile development practiced in the industry. Each small ball is a small change that is eligible for merge.Break the task down into as many parts as possible, as long as one meaningful PR for each of the parts exists. This helps in teams and communities to work independently and efficiently |
@SpyzzVVarun adding few more criteria
|
This issue needs a bit more attention now. Bumping updated time with this comment. |
@SpyzzVVarun are you available to work on this now? |
Marking issue as easy since a few improvements have been merged in the evaluation + revamp PR #118 |
Sir i would like to contribute to this project. Please tell me how, I'm pretty new to Open Source. |
@anaghninja432 Hello, if you're new to the project I suggest you to run the project locally on a new OMR sheet and submit a sample. Then in the process try to go through the code flow for your images. This task is around schema validation so you can experiment passing incorrect template jsons by thinking of common mistakes people can do. We need to provide accurate error messages to guide the user |
This extends #43
Originally posted by @Udayraj123 in #60 (comment)
The text was updated successfully, but these errors were encountered: