-
-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding schema validation for template configuration #60
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolve above comments
Need a separate issue for enhancements in schema:
|
use table for outputting errors: |
Is this part of this PR only or included in the enhancement issue? |
|
||
table = Table(show_lines = True) | ||
table.add_column("Key", style="cyan", no_wrap=True) | ||
table.add_column("Error", style="magenta") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
table can also come out. Make sure to reset it otherwise it's okay to keep inside.
src/utils/file.py
Outdated
from rich.console import Console | ||
from rich.table import Table | ||
import re | ||
from ..constants import SCHEMA_DEFAULTS_PATH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use absolute path, ..
is a bit error-prone
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Fixes #43 |
Sorry for the unnecessary amount of commits you see.
The main changes are as follows:
P.S. I am very new to Open Source Contribution and am open to any and all feedback.