Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't setup unmonitored pipes to child processes. #1360

Merged
merged 3 commits into from Feb 25, 2024
Merged

Conversation

troycurtisjr
Copy link
Member

This replaces the call out to the nohup and setsid executables with an in code implementation of re-opening the standard file descriptors to /dev/null. This avoids creating the pipes that has no reader and thus could block after enough output from the child process.

@troycurtisjr troycurtisjr merged commit cdcc4f4 into v6 Feb 25, 2024
2 checks passed
@troycurtisjr troycurtisjr deleted the alt-spawn branch February 25, 2024 19:54
Copy link
Member

@friday friday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants