Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: avoid refreshing triggers for every keystroke #1379

Merged
merged 1 commit into from
Apr 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 6 additions & 4 deletions ulauncher/modes/ModeHandler.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
_logger = logging.getLogger()
_events = EventBus("mode")
_modes: list[BaseMode] = []
_triggers: list[Result] = []


def get_modes() -> list[BaseMode]:
Expand Down Expand Up @@ -65,13 +66,14 @@ def get_mode_from_query(query: Query) -> BaseMode | None:
return None


def search(query: Query, min_score: int = 50, limit: int = 50) -> list[Result]:
searchables: list[Result] = []
def refresh_triggers() -> None:
for mode in get_modes():
searchables.extend([*mode.get_triggers()])
_triggers.extend([*mode.get_triggers()])


def search(query: Query, min_score: int = 50, limit: int = 50) -> list[Result]:
# Cast apps to AppResult objects. Default apps to Gio.DesktopAppInfo.get_all()
sorted_ = sorted(searchables, key=lambda i: i.search_score(query), reverse=True)[:limit]
sorted_ = sorted(_triggers, key=lambda i: i.search_score(query), reverse=True)[:limit]
return list(filter(lambda searchable: searchable.search_score(query) > min_score, sorted_))


Expand Down
1 change: 1 addition & 0 deletions ulauncher/ui/windows/UlauncherWindow.py
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,7 @@ def position_window(self) -> None:
self.move(pos_x, pos_y)

def show(self) -> None:
ModeHandler.refresh_triggers()
self.present()
# note: present_with_time is needed on some DEs to defeat focus stealing protection
# (Gnome 3 forks like Cinnamon or Budgie, but not Gnome 3 itself any longer)
Expand Down