Make ScriptArguments support flags #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ested ports is open nowadays
|
Hi @botastic, Sorry for the delay for some reason I wasn't watching this repo so didn't get any notifications or emails 😅 Looks good to me! Thanks for contributing :) |
Ullaakut
approved these changes
Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I modified the
WithScriptArgumentsfunction a bit in order to allow for flags as arguments. A flag can be handed to the function by simply leaving the value of the key-value pair empty. The test has also been adapted.As mentioned in my last PR: the first commits have been reverted, as I created the branches after submitting my first PR.
Best regards