-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.7] Can not save custom start gcode if it contains an equal sign #8230
Comments
Issue is likely related to the new FastConfigParser |
It would have been nice if this were discovered during the beta phase. |
Sorry, I downloaded beta and found this two hours before the release - and then confirmed it in release as well =( |
Yeah. Now that I see the g-code, it's pretty clear that the fast config parser caused this. I didn't know that stuff like this put in the start gcode. Is it because the beta period was too short? I'm noticing that we're getting less bug reports from the beta, only to recieve them on the first "real" release (hence the high number of patch releases we had to do the past few releases). |
Well, for me it was just a coincidence. I was preparing a 2-day print and tried tree supports, but they generated partly in the air (well, found out what infill for supports is for then) so I checked if a new version of Cura is around. I saw the beta, got it, found the bug, wanted to post it, saw that the release is there, got the release, checked again - and well, here we are ;) I just got into 3D-printing a month ago, but I think I will keep a closer look on upcoming betas to get into testing earlier ;) |
No problem. I'm just trying to figure out if there is anything we need to change in order to catch issues like this. Thanks for thinking along :) |
We have a fix for this issue (see the PR). We hope to release it somewhere next week. Thanks for the reports! I'm amazed that you figured out that the |
Beeing a software developer for 20 years now I messed up so many things I became quite good at analysing that stuff (even though I never did anything with Python yet). I tested the fix and can confirm it works for me now. Thanks a lot! |
It is not solved! |
I would suggest opening a new issue then. This issue is about the equal sign in gcode, which has been resolved and will be available in an upcoming release. Please attach the gcode to this new issue / fill out the template. |
How do i go about openning a new issue? |
Never mind... Just found it... Thanks |
Application version
4.7
Platform
Windows 10 2004 64bit
Printer
Ender 5
Reproduction steps
Screenshot(s)
Inserting this gcode:
Results in this:
Actual results
Cura is unusable and crashes on loading a stl.
Expected results
Custom gcode containing equal sign should work. It is required by Octolapse in this case.
Additional information
To reproduce this, I tried saving without equal signs - everything works (but Octolapse of course). I also checked the configuration files, and saving seems ok (I attached the file below). I think the issue comes from loading and parsing those config settings, as the equal sign is part of the configuration schema.
After digging around the code and commits a bit - maybe the new FastConfigParser has an issue with this? (Ultimaker/Uranium#625)
Creality+Ender-5_settings.inst.cfg.zip
The text was updated successfully, but these errors were encountered: