Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.6] Don't send extruder stack to CuraEngine when there is only 1 extruder #2009

Merged

Conversation

fieldOfView
Copy link
Collaborator

@fieldOfView fieldOfView commented Jun 21, 2017

This PR fixes an issue which causes settings to be ignored if a Custom FDM Printer is used with the number of extruders set to 1. Fixes #2007

When there is 1 extruder, the frontend stores all settings in the global stack. Sending an extruder stack confuses CuraEngine into using the values of the extruder stack, which results in defaults being used.

Basically, single extrusion Custom FDM Printers are broken at the moment, so if there were a point-release for Cura 2.6 it would be great if this fix could be included.

Steps to reproduce:

  • Add a Custom FDM Printer
  • Keep number of extruders to 1, keep diameter at 2.85
  • Slice an object, and note down the estimated length of material.
  • Change the diameter to 1.75 in the sidebar
  • Note that after slicing the estimated length has changed
  • Save the gcode file, and inspect the last G1 before the end gcode

Expected:
The E-value for the last G1 reflects the changed amount of material

Actual:
The E-value for the last G1 reflects the original amount of material, for 2.85 mm diameter.

…ne extruder

When there is 1 extruder, the frontend stores all settings in the global stack. Sending an extruder stack confuses CuraEngine into using the values of the extruder stack, which results in defaults being used.
@fieldOfView fieldOfView changed the title Don't send extruder stack to CuraEngine when there is 1 extruder [2.6] Don't send extruder stack to CuraEngine when there is only 1 extruder Jun 21, 2017
@nallath nallath merged commit de01155 into Ultimaker:2.6 Jun 22, 2017
@nallath
Copy link
Member

nallath commented Jun 22, 2017

Thanks for the fast fix!

@BagelOrb
Copy link
Contributor

BagelOrb commented Jun 22, 2017

The problem seems fixed, but when I create a new Custon FDM Printer, the default material diameter is set to 1.75. Changing it to 2.85 doesn't have any effect on the material diameter in the side panel.

It seems to me that the material diameter should be removed from the machine settings...

If I change the side-panel value, the machine setting changes along, but not the other way around.

@fieldOfView
Copy link
Collaborator Author

fieldOfView commented Jun 22, 2017

It seems to me that the material diameter should be removed from the machine settings...

We need a way to set the filament diameter the printer requires.

the default material diameter is set to 1.75. Changing it to 2.85 doesn't have any effect on the material diameter in the side panel.

Hmm, the problem is that the diameter gets overridden by the currently active material... Something to fix in Cura 2.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants