Remove tray icon while the application is still alive #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Developers, see issue CURA-5935. |
|
It would be a shame if this persisted in Cura 4.0 |
|
Just to emphasize that this simple, low-risk fix needs to be in Cura 4.0, I have changed the base branch to 4.0. This issue is (unjustifiably) seen as an indication of a memory leak: https://community.ultimaker.com/topic/24900-cura-35-memory-leak-in-monitor/?page=2&tab=comments#comment-222467 |
|
Merged together with @nallath |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR actively removes the tray icon before the application is shut down, so the tray icon does not get orphaned. Without this PR, an orphan tray icon is left behind each time Cura is shut down.