Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give include priority to the SIP include path. #46

Merged
merged 1 commit into from
Nov 19, 2016

Conversation

kakaroto
Copy link
Contributor

@kakaroto kakaroto commented Nov 3, 2016

This causes an issue with cura-build if a newer SIP version is installed on the system,
then the python include path would take precedence and Arcus would require
a newer SIP API than the one that comes bundled with cura.

This will finally get rid of this error if sip 4.18 is installed locally while Arcus gets compiled by the cura-build script :

An uncaught exception has occurred!
Traceback (most recent call last):
  File "./bin/cura2", line 47, in <module>
    import Arcus #@UnusedImport
Runtime Error: the sip module implements API v11.0 to v11.2 but the Arcus module requires API v11.3

This causes an issue with cura-build if a newer SIP version is installed on the system,
then the python include path would take precedence and Arcus would require
a newer SIP API than the one that comes bundled with cura.
@nickthetait
Copy link

Any update on this one?

@Ghostkeeper
Copy link
Contributor

I don't feel qualified enough to judge the impact of this change. I'd like @awhiemstra or @sedwards2009 to take a look at it.

@thopiekar
Copy link
Contributor

For me this change makes sense. You can blame it on me if it breaks something 🙈

@thopiekar thopiekar merged commit 2c648e5 into Ultimaker:master Nov 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants