-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Axis controls don't match OctoPrint (ie: inverted setting) #849
Comments
I'll try that later once I have access to the printer again. I use the API and don't send GCode directly to the printer, that's why I though OctoPrint would apply everything user configured automatically. I'll have a look at that. |
@UnchartedBull, I would have made the same assumption. I had some time this afternoon so I took a stab at a fix, and submitted the pull request. Fair warning, I haven't done much UI work in years and have not worked with TS or Angular before, but hopefully I wasn't too far off the mark, or at least maybe it's a starting point for you. At some point it might be worth getting the full list of printer profiles from the API and looking for the one flagged as the current profile, but for now I went ahead and just used the "_default" profile which will probably work for 99% of users. |
That's a great PR! It is definitely a very good starting point and probably will be used as is for the next couple versions until the printer profiles get fully implemented. There are some other interesting aspects in there as well, i.e. axis speeds and stuff which would make the configuration of OctoDash easier. Thank you again for your PR. |
* Fix #849 ; Respect the OctoPrint axis invert flags * Fix #849 ; Fix NRE and clean up code a bit * PR Changes for issue #849 based on CodeFactor requirements * Update src/app/printerprofile.service.ts Simplifying code based on @UnchartedBull feedback Co-authored-by: Timon G. <timon.gaebelein@icloud.com> * Update Promise handling based on @UnchartedBull feedback Co-authored-by: Peter Femiani <peter.femiani@match.com> Co-authored-by: Timon G. <timon.gaebelein@icloud.com>
…nchartedBull#856) * Fix UnchartedBull#849 ; Respect the OctoPrint axis invert flags * Fix UnchartedBull#849 ; Fix NRE and clean up code a bit * PR Changes for issue UnchartedBull#849 based on CodeFactor requirements * Update src/app/printerprofile.service.ts Simplifying code based on @UnchartedBull feedback Co-authored-by: Timon G. <timon.gaebelein@icloud.com> * Update Promise handling based on @UnchartedBull feedback Co-authored-by: Peter Femiani <peter.femiani@match.com> Co-authored-by: Timon G. <timon.gaebelein@icloud.com>
When using the control screen to move the toolhead X/Y/Z the controls don't respect the axis inversion settings in OctoPrint
Steps to reproduce the behavior:
The text was updated successfully, but these errors were encountered: