Correctly Set Sub-Function Names #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
steviegt6
changed the title
|
Download the artifacts for this pull request here: GUI:
CLI: |
Beneficial to code cleanliness and provides ever-so-slight code optimizations.
Miepee
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1035.
Description
Changes function decompilation behavior to use the associated sub-function name if possible. Without this, ever sub-function takes on the name of the function defined in the first statement of the decompilation context, which of course spells issues.
Caveats
No caveats that I am aware of - everything works the same, and I confirmed that recompilation works as well.
Notes
I have confirmed that recompilation and everything works fine. I'm not too familiar with the codebase and the inner workings of everything, so please verify this PR if needed.
If there is a better way to get the sub-function (especially if there is a way that doesn't require LINQ), please tell me.