Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to Java 11 #432

Closed
kohlhase opened this issue Feb 12, 2019 · 6 comments
Closed

switch to Java 11 #432

kohlhase opened this issue Feb 12, 2019 · 6 comments
Assignees
Labels
systems-meeting To be discussed in the KWARC system meeting soon.
Milestone

Comments

@kohlhase
Copy link
Member

it is the new lts version.

@kohlhase kohlhase added the systems-meeting To be discussed in the KWARC system meeting soon. label Feb 12, 2019
@kohlhase kohlhase mentioned this issue Feb 12, 2019
6 tasks
@kohlhase kohlhase modified the milestones: Release 17, Release 19 Feb 12, 2019
tkw1536 added a commit that referenced this issue Feb 12, 2019
This commit switches the Dockerfile for MMT to use JDK 11, in
preparation of #432
@tkw1536
Copy link
Contributor

tkw1536 commented Feb 12, 2019

I have updated:

  • the Travis Tests to test on both Java 8 and Java 11
  • the Dockerfile (mostly used in MathHub) to use Java 11

@lambdaTotoro
Copy link
Contributor

What else needs to be done?

@ComFreek
Copy link
Member

ComFreek commented Mar 13, 2019

I've seen Illegal reflective access by com.google.protobuf.UnsafeUtil to field java.nio.Buffer.address occurring during build. Apparently, this issue has been closed from Google's side (see protocolbuffers/protobuf#3781). Are we depending on an older version of protobuf?

Edit: Build log says:

WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.google.protobuf.UnsafeUtil (file:/C:/Users/ComFreek/.sbt/boot/scala-2.12.7/org.scala-sbt/sbt/1.2.8/protobuf-java-3.3.1.jar) to field java.nio.Buffer.address
WARNING: Please consider reporting this to the maintainers of com.google.protobuf.UnsafeUtil
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

Apparently, it's due to the Scala 2.12.7 dependency. Maybe increasing the Scala version (of the unmanaged libraries in deploy/lib as well) helps?

@kohlhase kohlhase modified the milestones: Release 19, Release 17 Apr 24, 2019
@kohlhase
Copy link
Member Author

This seems almost done, targetting to release 17.
We also need to adapt https://uniformal.github.io/doc/setup/

@tkw1536 tkw1536 modified the milestones: Release 17, Release 18 May 14, 2019
@tkw1536
Copy link
Contributor

tkw1536 commented May 14, 2019

Not sure this is doable for Release 17, re-scheduling for release 18

@kohlhase kohlhase modified the milestones: Release 18, Release 20 Aug 13, 2020
@lambdaTotoro lambdaTotoro modified the milestones: Release 20, Release 21 Oct 16, 2020
@ComFreek
Copy link
Member

The latest Travis CI has been running JDK 14 to build MMT fine for several weeks. So this case is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
systems-meeting To be discussed in the KWARC system meeting soon.
Projects
None yet
Development

No branches or pull requests

4 participants