Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

[WIP] General authorization #119

Closed
wants to merge 7 commits into from

Conversation

shine2lay
Copy link

Goal

Add the general authorization described in : closes #88

Changes

TODO: list all the changes in the PR

Copy link
Contributor

@Kyrrui Kyrrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The contract names should be Uppercase in accordance with the rest of the projects - "AuthorizationInterface.sol" rather than "authorizationInterface.sol"

@marekkirejczyk
Copy link
Contributor

Hi @shine2lay!

Since the plan for authorization is not yet final I propose we treat it is a test/research implementation and move it to proposals repository.

@shine2lay
Copy link
Author

shine2lay commented Nov 23, 2018

@marekkirejczyk
I think there are two parts to the authorizations,

  1. The interface of authorization Contract
  2. ways to handle complex multi-authorizations checking in SignedApprovalScheme.sol

I think the interface of the authorization contract is somewhat final (unless this implementation brings up issues we haven't considered to light).
My current work so far is to make sure that that interface is working and we can make one authorization check happen. Once this is working, adding multiple checks will work for sure no matter how we complex we decide to implement it.

I think the 2nd part is going to very complex and it may not even be necessary at the moment. I think it is something that will evolve overtime as requirements and use cases becomes clearer. We may even end up having different version of wallet contract that serves different purposes.

@marekkirejczyk
Copy link
Contributor

Would you like to make a call early next week to sync?

@shine2lay
Copy link
Author

@marekkirejczyk I can only do Thursday or Friday next week.

@marekkirejczyk
Copy link
Contributor

Hi, shot me an email on marek (at) ethwroks . io and let's start moving!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Having a generic authorization contract for each key
3 participants