Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoids very numerous warnings about delimiting key for scope cat #1829

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

rmatthes
Copy link
Member

@rmatthes rmatthes commented Jan 25, 2024

the scope Cat is given up and its uses replaced by either cat or no scope declaration

Resolves #1791

…sue 1791

the scope Cat is given up and it uses replaced by either cat or no scope declaration
@rmatthes
Copy link
Member Author

I have filed PR to correct the issues with largecatmodules and TypeTheory.

@rmatthes
Copy link
Member Author

I do not know how to react to the error messages coming from Coq 8.20alpha. They appear in files I did not touch on:

  • UniMath/Bicategories/DisplayedBicats/Examples/Codomain.v
  • UniMath/Bicategories/OrthogonalFactorization/EsoFactorizationSystem.v

@nmvdw
Copy link
Collaborator

nmvdw commented Jan 25, 2024

I do not know how to react to the error messages coming from Coq 8.20alpha. They appear in files I did not touch on:

  • UniMath/Bicategories/DisplayedBicats/Examples/Codomain.v
  • UniMath/Bicategories/OrthogonalFactorization/EsoFactorizationSystem.v

It seems like there was a change to a Coq version that affected some code (I don't have the developer version of Coq)

@benediktahrens
Copy link
Member

@rmatthes : thanks for preparing these PRs! I would like to let them sit for a few days, to give people a chance to evaluate them and comment. I don't know the scope mechanism well myself.

@rmatthes
Copy link
Member Author

@benediktahrens I see no dynamics - what would trigger that the PR can be merged?

@benediktahrens benediktahrens merged commit 1c2cce1 into UniMath:master Jan 30, 2024
6 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A warning
3 participants