Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated version of #1822 #1851

Merged
merged 37 commits into from Feb 26, 2024
Merged

Updated version of #1822 #1851

merged 37 commits into from Feb 26, 2024

Conversation

benediktahrens
Copy link
Member

This PR is an updated version of #1822

@benediktahrens
Copy link
Member Author

Merging this now without waiting for the macOS build.

@benediktahrens benediktahrens merged commit b6dd146 into UniMath:master Feb 26, 2024
10 of 11 checks passed
@proux01
Copy link
Contributor

proux01 commented Feb 28, 2024

@DenSinH @nmvdw @benediktahrens merging this PR broke Coq CI (see for instance coq/coq#18713 that ran yesterday). The compilation of files UniMath/ModelCategories/Generated/LNWFSClosed.v and UniMath/ModelCategories/Generated/LNWFSClosed.v is very slow (multiple dozen minutes) and triggers the 1h timeout there. We are going to exclude package ModelCategories from Coq CI unless you have a better solution.

@nmvdw
Copy link
Collaborator

nmvdw commented Feb 28, 2024

I agree with your solution. We put ModelCategories in a separate package for that purpose.

@DenSinH
Copy link
Contributor

DenSinH commented Feb 28, 2024

The compile times are due to some changes I had to make for this package to work with the recent changes in UniMath. If I recall correctly, the definitions for monads have changed slightly, and those for comonads have been added. These are apparently significantly slower somehow...

@nmvdw
Copy link
Collaborator

nmvdw commented Feb 28, 2024

The compile times are due to some changes I had to make for this package to work with the recent changes in UniMath. If I recall correctly, the definitions for monads have changed slightly, and those for comonads have been added. These are apparently significantly slower somehow...

I see. Such changes might require some minor refactoring at some other parts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants