Compatibility with Coq PR #7257 fixing the result of a "random" unification heuristic. #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c order. See Coq PR #7257. Unfortunately, the heuristic was working because a variable was called y. Would have it been called v, it would not have worked. We fix it by giving a more refine pattern to help unification.
|
@herbelin Thank you for contributing a fix! It's great that the Coq developers think so much about their users 😄 |
langston-barrett
approved these changes
Apr 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm very sorry, but a bug-fix PR, number coq/coq#7257, is causing an incompatibility in UniMath. Indeed, we discovered that some unification heuristic was sensitive to the alphabetic order and a PR has been proposed to use a more stable heuristic. In UniMath's file
Algebra/Modules/Core.v, there is indeed an example of a unification problem which is sensitive to the name of some variable. The problem works because a variable is calledybut it would not have worked if the variable had been calledvbecause it involves another variablex, andv<x<yalphabetically :(((We fix the file by giving a more refined pattern to help unification.