Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The concepts macro should require the WD field if the WDID field is specified and vice versa #1076

Closed
fredrik-bakke opened this issue Mar 14, 2024 · 0 comments · Fixed by #1093
Closed

The concepts macro should require the WD field if the WDID field is specified and vice versa #1076

fredrik-bakke opened this issue Mar 14, 2024 · 0 comments · Fixed by #1093
Labels
CI

Comments

@fredrik-bakke
Copy link
Collaborator

If either data point is specified, the other one should also be possible to determine, and making them corequired will avoid incomplete specifications.
@VojtechStep VojtechStep mentioned this issue Mar 22, 2024
Merged
fredrik-bakke pushed a commit that referenced this issue Mar 23, 2024
@VojtechStep
Enhancements for the Concepts macro (#1093)
cacce49 
This PR:
- Makes concepts throw an error when a wikidata ID is provided without a
label. Fixes #1076
- Uses lowercase wikidata labels in the concept tags, and only
capitalizes them when generating links. Fixes #1077
- Disallows newlines in quoted parts of the macro. Fixes #1092 
- Correctly finds Agda definitions which have single-quotes in them.
Fixes #1075
- Adds "(disambiguation)" to concept names in the database, when a
disambiguation is provided
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enhancements for the Concepts macro VojtechStep/agda-unimath
1 participant
@fredrik-bakke