Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve duplicate definitions #992

Closed
5 tasks done
VojtechStep opened this issue Jan 5, 2024 · 0 comments · Fixed by #1022
Closed
5 tasks done

Resolve duplicate definitions #992

VojtechStep opened this issue Jan 5, 2024 · 0 comments · Fixed by #1022
Assignees
Labels
cleanup help wanted Extra attention is needed

Comments

@VojtechStep
Copy link
Collaborator

VojtechStep commented Jan 5, 2024

We aim to have unique identifiers for all public definitions throughout the codebase, as stated in the library coding style guide. This was supposed to be enforced by recursively opening all modules of the library, so that Agda would complain about duplicate definitions when checking the Everything file.

Unfortunately we aren't properly opening the top-level modules, so while we avoided naming collisions inside top-level modules, we managed to introduce duplicates across top-level module boundaries. These should be resolved by either removing one of the definitions, and reusing the other, or by renaming one or both definitions to something less ambiguous.

So far I found the following duplicates:

  • Theory of finite groups is duplicated between finite-algebra and finite-group-theory. The finite-algebra module should build on top of the formalization from finite-group-theory
  • foundation.separated-types.is-separated vs orthogonal-factorization-systems.separated-types.is-separated
  • univalent-combinatorics.standard-finite-types.Fin vs reflection.group-solver.Fin
  • universal-algebra.terms-over-signatures.Term vs reflections.terms.Term
  • foundation.path-algebra.cube vs univalent-combinatorics.cubes.cube

The Everything file is generated by a script in the Makefile, so once the duplicates are resolved, we should change the script to generate open import <module> public lines.

@VojtechStep VojtechStep added help wanted Extra attention is needed cleanup labels Jan 5, 2024
@fredrik-bakke fredrik-bakke self-assigned this Feb 6, 2024
EgbertRijke pushed a commit that referenced this issue Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants