Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self-host GoatCounter script #1046

Merged
merged 7 commits into from
Mar 1, 2024
Merged

Conversation

fredrik-bakke
Copy link
Collaborator

@fredrik-bakke fredrik-bakke commented Feb 28, 2024

Makes us self-host the GoatCounter script. Perhaps this will avoid some more tracker blockers. The hosted script is a minified version of the original one.

Follow-up to #1035.

@fredrik-bakke fredrik-bakke marked this pull request as ready for review February 28, 2024 14:11
@fredrik-bakke
Copy link
Collaborator Author

I'm having trouble building the website locally due to a new version of Python 🤦‍♂️

@VojtechStep
Copy link
Collaborator

If we're pretty-printing the mangled script then maybe just include it in the original form. Also the ISC license notice from the original file has to be included at the top of the file.

@fredrik-bakke
Copy link
Collaborator Author

Oh, shoot, I thought I had pushed the change

Copy link
Collaborator

@VojtechStep VojtechStep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fredrik-bakke fredrik-bakke merged commit 106965f into UniMath:master Mar 1, 2024
4 checks passed
@fredrik-bakke fredrik-bakke deleted the analytics2 branch March 1, 2024 16:20
fredrik-bakke added a commit that referenced this pull request Mar 1, 2024
fredrik-bakke added a commit that referenced this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants