Fail the website build on unparsed concept macro invocations #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VojtechStep
force-pushed
the
fixup/concept-right-whiskering
branch
from
c115135
to
60681b8
Compare
fredrik-bakke
approved these changes
Mar 12, 2024
fredrik-bakke
pushed a commit
to fredrik-bakke/agda-unimath
that referenced
this pull request
Mar 14, 2024
…h#1066) I found two instances where the concepts macro wasn't formatted properly, so I added a check to the preprocessor that fails the website build. This means that the preprocessor will run in full for the `linkcheck` output. We could have it only do some of the work for just checking if all the tags are well-formatted, but most of the time is still spent in IO with the `mdbook` process, which we can't speed up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found two instances where the concepts macro wasn't formatted properly, so I added a check to the preprocessor that fails the website build.
This means that the preprocessor will run in full for the
linkcheckoutput. We could have it only do some of the work for just checking if all the tags are well-formatted, but most of the time is still spent in IO with themdbookprocess, which we can't speed up.