Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various website improvements #1154

Merged
merged 5 commits into from
Jun 6, 2024

Conversation

VojtechStep
Copy link
Collaborator

@VojtechStep VojtechStep commented Jun 6, 2024

@VojtechStep VojtechStep added enhancement New feature or request website labels Jun 6, 2024
@fredrik-bakke
Copy link
Collaborator

It can also be noted that this PR reduced the font size in code blocks from 15.68 px to 14.56px and increases the font size in text code blocks from 13.72 px to 14.56px.

Copy link
Collaborator

@fredrik-bakke fredrik-bakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am very happy with these changes. And thanks for also helping me with some of my issues!

@fredrik-bakke
Copy link
Collaborator

fredrik-bakke commented Jun 6, 2024

Oh, there seems to be a rendering issue actually. Compare this:

image

to the live website:

image

EDIT: The left-hand bar doesn't collapse properly, and git metadata is not present.

Copy link
Collaborator

@fredrik-bakke fredrik-bakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above mentioned issue

@VojtechStep
Copy link
Collaborator Author

Git metadata is not present because we only enable it for CI, not locally, see https://github.com/UniMath/agda-unimath/blob/master/.github%2Fworkflows%2Fpages.yaml#L96-L97

The sidebar issue reminds me of some breakage that happened when we tried to update mdbook. Could you check that you're running 0.4.34? This version is pinned in the Makefile for install-website-dev and the CI script.

Could you compare it with a local build from master, not the live version?

@fredrik-bakke
Copy link
Collaborator

ah shoot, I'm running mdbook v.0.4.40

Copy link
Collaborator

@fredrik-bakke fredrik-bakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these are known issues that are explained by a version mismatch in my local installation I'll go ahead and approve this again

@fredrik-bakke
Copy link
Collaborator

Yep, the same issue is present for me when building from master. I'll merge this PR now.

@fredrik-bakke fredrik-bakke merged commit d2af015 into UniMath:master Jun 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fix website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent font sizes in code blocks
2 participants