Definition of dirichlet series #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…verse.lagda.md. I have Dirichlet series for species of finite inhabited types and for species of types in subuniverses. I also defined the product for each of these series
src/species/dirichlet-series-species-of-finite-inhabited-types.lagda.md
Outdated
Show resolved
Hide resolved
src/species/dirichlet-series-species-of-finite-inhabited-types.lagda.md
Outdated
Show resolved
Hide resolved
src/species/dirichlet-series-species-of-finite-inhabited-types.lagda.md
Outdated
Show resolved
Hide resolved
src/species/dirichlet-series-species-of-finite-inhabited-types.lagda.md
Outdated
Show resolved
Hide resolved
src/species/dirichlet-series-species-of-finite-inhabited-types.lagda.md
Outdated
Show resolved
Hide resolved
src/species/dirichlet-series-species-of-types-in-subuniverses.lagda.md
Outdated
Show resolved
Hide resolved
src/species/products-dirichlet-series-species-of-finite-inhabited-types.lagda.md
Outdated
Show resolved
Hide resolved
src/species/products-dirichlet-series-species-of-types-in-subuniverses.lagda.md
Outdated
Show resolved
Hide resolved
|
Thank you for the review :) |
|
Alright, I don't have anything more to add at this point. I'll wait and see if Egbert has anything to add, but otherwise, it's good to merge I think. |
|
Nice, thank you :) . |
|
Thanks for the question. Ideally, you would branch from your current PR branch, and then rebase onto agda-unimath/master after this PR is merged, I think. However, this is tricky to do(read: I mess this up every time) so I'll do you a favour and merge this PR now. |
|
Thank you so much :) |
|
Excellent! I agree with the merge. Good work! |
|
This PR suffered from #595 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have cleaned the file
dirichlet-products-species-of-types-in-subuniverse.lagda.md.I have defined Dirichlet series for species of finite inhabited types and for species of types in subuniverses.
I have also defined the product for each of these series