Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exploitable Upload method in "UploadController.php" #32

Closed
rebootcode opened this issue Feb 22, 2016 · 4 comments
Closed

Exploitable Upload method in "UploadController.php" #32

rebootcode opened this issue Feb 22, 2016 · 4 comments
Labels
bug Behaviors that do not meet expectation.
Milestone

Comments

@rebootcode
Copy link

Hi, there is no file upload validation check here :- https://github.com/UniSharp/laravel-filemanager/blob/master/src/controllers/UploadController.php#L40 ?

On given fact , "Upload" can be done with any method "GET|HEAD|POST|PUT|PATCH|DELETE" ??

@youchenlee
Copy link
Member

Hi @rebootcode
The upload() method will be dispatched by routes.php and should be authendicated by Middlewares (https://github.com/UniSharp/laravel-filemanager/blob/master/src/routes.php#L6)

@youchenlee youchenlee added the question Already has a solution. No further action is required. label Feb 22, 2016
@rebootcode
Copy link
Author

well, question is not about authentication, question is about uploadType , you should add file type allowed , as any user can upload "php" or other file type. @youchenlee

This is not question, this is security issue

@youchenlee youchenlee added enhancement Optimization for existing features. and removed question Already has a solution. No further action is required. labels Feb 23, 2016
@youchenlee
Copy link
Member

@rebootcode Appreciate your suggestion. It would be great to have a whitelist of available MIME types or file extensions configurations.

youchenlee added a commit that referenced this issue Mar 5, 2016
…t pdf/docs upload #29

Also remove Session, I don't see why filemanager need session.
@youchenlee
Copy link
Member

The release 1.3.0-alpha should fix this.
I will close this issue after a few more tests.

@youchenlee youchenlee added WIP Working in progress. bug Behaviors that do not meet expectation. and removed enhancement Optimization for existing features. labels Mar 5, 2016
@youchenlee youchenlee added this to the v1.3 milestone Mar 5, 2016
@youchenlee youchenlee removed the WIP Working in progress. label Mar 12, 2016
ana-lisboa pushed a commit to ana-lisboa/laravel-filemanager that referenced this issue Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Behaviors that do not meet expectation.
Projects
None yet
Development

No branches or pull requests

2 participants