Dependency Manager in core

[Glavin001]

Add support for beautifiers with executables (port from Atom-Beautify)

See Glavin001/atom-beautify#1687

• Dependencies
  • Node
    • require (builtin)
    • requireg (global)
    • Project specific (local) (moved to Add support for local (project specific) Node dependency #81 )
  • Executable
    • Configurable program path
    • Docker (moved to Add Docker dependency support #80 )
• Error handling
  • Add the errors for the dependency to https://github.com/Unibeautify/unibeautify/blob/master/src/DependencyManager/Dependency.ts#L32

[Glavin001]

I'm thinking of adding a dependencies property to the Beautifier.

Modelled after VSCode's launch.json: https://code.visualstudio.com/docs/editor/debugging#_launch-configurations

{
  "dependencies": [
    {
      "type": "node",
      "name": "Prettier",
      "package": "prettier"
    },
    {
      "type": "exec",
      "name": "PHP-CS-Fixer",
      "program": "php-cs-fixer",
      "version": {
        "parse": (text: string) => {
          try {
            return text.match(/version (.*) by/)[1] + ".0";
          } catch (error) {
            return text.match(/PHP CS Fixer (\d+\.\d+\.\d+)/)[1];
          }
        }
      },
      "docker": {
        "image": "unibeautify/php-cs-fixer"
      }
    },
  ]
}

[Glavin001]

Dependency types

node

Node.js package. Can be required from various sources, in order:

1. local (in node_modules)
2. global (requireg)
3. builtin (such as editor extension)

exec

Execute a non-Node.js module from command-line.
Test installation by checking version.

docker

Fallback to using Docker.

[Glavin001]

Another idea is:

{
  "dependencies": {
    "Prettier": {
      "type": "node",
      "package": "prettier"
    },
    "PHP-CS-Fixer": {
      "type": "exec",
      "program": "php-cs-fixer",
      "version": {
        "parse": (text: string) => {
          try {
            return text.match(/version (.*) by/)[1] + ".0";
          } catch (error) {
            return text.match(/PHP CS Fixer (\d+\.\d+\.\d+)/)[1];
          }
        }
      },
      "docker": {
        "image": "unibeautify/php-cs-fixer"
      }
    }
  }
}

[stevenzeck]

I would vote for the first example.

[Glavin001]

@szeck87 : Feel free to use the 👍 reaction 😉.

I do as well and am implementing it as such now.

[Glavin001]

Pull Request in progress! #63

[Glavin001]

Published to v0.12.0