WIP: Dependency manager #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do not merge. Still lots to do! Please feel free to make comments. This is a critical feature and I want it built right. |
|
@szeck87 : Can now see Coverage page by adding |
…r/push 🎨 Fix formatting of 8 files for commit b163082
…r/push 🎨 Fix formatting of 4 files for commit 43612fe
This was referenced Apr 1, 2018
stevenzeck
suggested changes
Apr 4, 2018
|
|
||
| public load(): Promise<boolean> { | ||
| if (this.isInstalled) { | ||
| return Promise.resolve(this.isInstalled); |
There was a problem hiding this comment.
This needs code coverage.
| return patterns.reduce( | ||
| (extracted: string | undefined, pattern: string | RegExp) => { | ||
| if (extracted) { | ||
| return extracted; |
There was a problem hiding this comment.
This needs code coverage.
| return (stdout += data); | ||
| }); | ||
| cmd.stderr.on("data", data => { | ||
| return (stderr += data); |
There was a problem hiding this comment.
This needs code coverage.
| return reject(err); | ||
| }); | ||
| if (stdin) { | ||
| cmd.stdin.end(stdin); |
There was a problem hiding this comment.
This needs code coverage.
|
And if we want to hit 100% code coverage, this line too: |
stevenzeck
previously approved these changes
Apr 5, 2018
stevenzeck
previously approved these changes
Apr 5, 2018
…r/push 🎨 Fix formatting of 2 files for commit 770e218
stevenzeck
approved these changes
Apr 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #58
Example: https://github.com/Unibeautify/beautifier-php-cs-fixer