Plotting fixes #1254
Merged
Plotting fixes #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal of the original implementation was to avoid triggering matplotlib backend detection code on import by avoiding importing the pyplot interface. This seems no longer necessary, and more importantly it doesn't work just to use figure.show(), so just use plt.show()
dopplershift
added
Area: Plots
|
This pull request introduces 1 alert when merging 0284f43 into ff1bb66 - view on LGTM.com new alerts:
|
This was working around CartoPy <=0.14.3 issues for transforming vectors. Latest CartoPy is 0.17.0. 0.15.0 is almost 3 years old at this point, I think we can rely on it.
dopplershift
force-pushed
the
plotting-fixes
branch
from
0284f43
to
9c8632f
Compare
Without this, things are ending up in an unexpected directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
show()implementation: we were trying to avoidpyplot.show(), butfigure.show()is insufficient. Also, we usepyplotall over the place now, so no need (Declarative show() does not pop up GUI #1207)StationPlot. This was for CartoPy <= 0.14.3. CartoPy 0.15.0 is almost 3 years old now. (Remove Cartopy workaround from stationplot #1229)Checklist