Xarray accessor updates to remove automatic quantification and in-place operations #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CartoPy 0.18 started validating scales for NaturalEarthFeature, which breaks with the scales for our own map features. There's really no reason to inherit from NaturalEarthFeature, so just make this inherit Feature and add a few missing things.
Matplotlib (as of 3.2.2) does not properly clip text to paths. For now, add a clipbox for the Axes bounding box, which will supplement the set clip path.
0.18 started autoscaling map features and updated some gridline handling, causing changes to our test images.
jthielen
added
Area: Xarray
15 tasks
|
Closing since I had to re-create my MetPy fork, which means this PR no longer has a valid reference. Will put up a new PR once master is in a stable enough state that I can avoid too many rebases on antecedent patches. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Based on lingering discussions (particularly in #1354), this PR implements a few cleanups on the xarray accessors needed for work on #1353 to continue, namely, removing automatic conversion to quantities in
parse_cf(since its loading of data into memory can cause errors) and making sure all operations are not in-place. There is one place where "side effects" still occur (caching of the coordinate parsing results in the _metpy_axis attribute), but I figured this was still okay (and hard to avoid, since it is invoked when using a property).Also, I've left this PR in draft status, since it depends on #1372 for Cartopy 0.18 fixes and #1373 for flake8/pylint fixes.
Checklist