New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xarray accessor updates to remove automatic quantification and in-place operations #1430
Xarray accessor updates to remove automatic quantification and in-place operations #1430
Conversation
I realized that this uses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. I like the extensive additions in notes in the docs and comments.
Eh, what's another two months shorter on our xarray horizon? Go ahead and bump. Would just 0.14.0 work? (Could always let our tests determine that.) If not 0.14.1's fine. Hey does that mean we can work around some of those deprecated functions now? 😄 |
Answered my own question here as I did some digging for other reasons. We need 0.14.1 for |
Yeah, xarray hasn't been the best at following semver...their "patch" releases sometimes have new APIs and breaking changes.
I'll take a look after this PR! |
a2772ba
to
699d161
Compare
699d161
to
f6191eb
Compare
Not sure why Travis shows queued, it's passed. Codacy is...well, wrong. |
So now it's mostly just the updated version of #1353 to go before 1.0-rc2? |
Sounds great. I promise this one will actually get my attention. Thanks for knocking these out. I'm really happy with how CI is working with these. |
Description Of Changes
Update of #1378 on new fork and after rebase on latest master. Original comment below:
Checklist