Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make grid args for divergence and vorticity keyword-only #1521

Merged
merged 4 commits into from Oct 2, 2020

Conversation

jthielen
Copy link
Collaborator

@jthielen jthielen commented Oct 1, 2020

Description Of Changes

Make grid arguments for divergence and vorticity keyword-only in anticipation of 3D support later in 1.x series as described in #1519.

Checklist

@jthielen jthielen added Area: Calc Pertains to calculations Type: API Change Changes to how existing functionality works labels Oct 1, 2020
@jthielen jthielen added this to the 1.0 milestone Oct 1, 2020
@lgtm-com
Copy link

lgtm-com bot commented Oct 1, 2020

This pull request introduces 1 alert when merging 6407594 into 69f86f9 - view on LGTM.com

new alerts:

  • 1 for Unused import

dopplershift
dopplershift previously approved these changes Oct 2, 2020
dcamron
dcamron previously approved these changes Oct 2, 2020
Copy link
Member

@dcamron dcamron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just punctuation consistency, if it's worth changing. Otherwise good to go!

src/metpy/calc/kinematics.py Outdated Show resolved Hide resolved
src/metpy/calc/kinematics.py Outdated Show resolved Hide resolved
@dopplershift dopplershift dismissed stale reviews from dcamron and themself via db22ca5 October 2, 2020 18:23
@dcamron dcamron merged commit db2a433 into Unidata:master Oct 2, 2020
@jthielen jthielen deleted the grid-args-keyword-only branch January 18, 2021 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Calc Pertains to calculations Type: API Change Changes to how existing functionality works
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Making grid arguments for divergence and vorticity keyword-only as forward-looking API change
3 participants