Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo xarray with MetPy tutorial for 1.0 #1605

Merged
merged 5 commits into from Dec 16, 2020

Conversation

jthielen
Copy link
Collaborator

@jthielen jthielen commented Dec 8, 2020

Description Of Changes

Overhaul the xarray with MetPy tutorial given the substantial changes in xarray support for the 1.0 release. Part of the remaining effort towards #1385. This makes extensive use of HTML reprs for xarray and Pint, so it is nice that we've gotten that working seemingly well with the new theme.

Checklist

  • Closes
  • Tests added
  • Fully documented

@jthielen jthielen added Area: Docs Affects documentation Area: Xarray Pertains to xarray integration labels Dec 8, 2020
@jthielen jthielen added this to the 1.0 milestone Dec 8, 2020
@lgtm-com
Copy link

lgtm-com bot commented Dec 8, 2020

This pull request introduces 1 alert when merging 4581a27 into f991506 - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

Copy link
Member

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great work. I just found a few minor things here.

tutorials/xarray_tutorial.py Outdated Show resolved Hide resolved
tutorials/xarray_tutorial.py Outdated Show resolved Hide resolved
tutorials/xarray_tutorial.py Outdated Show resolved Hide resolved
tutorials/xarray_tutorial.py Outdated Show resolved Hide resolved
tutorials/xarray_tutorial.py Outdated Show resolved Hide resolved
@dopplershift dopplershift added the Type: Enhancement Enhancement to existing functionality label Dec 9, 2020
@lgtm-com
Copy link

lgtm-com bot commented Dec 10, 2020

This pull request introduces 1 alert when merging 4f5d697 into 495061a - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

@dopplershift
Copy link
Member

If you rebase on master, that should clean up Code Climate.

@jthielen
Copy link
Collaborator Author

Remaining comments should now have been addressed, and I've rebased on master.

dopplershift
dopplershift previously approved these changes Dec 10, 2020
Copy link
Member

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can think of a way to make LGTM happy, great. Regardless, I'm happy to merge, though.

dopplershift
dopplershift previously approved these changes Dec 10, 2020
@dopplershift dopplershift merged commit b5e3942 into Unidata:master Dec 16, 2020
@jthielen jthielen deleted the xarray-guide-1.0 branch January 18, 2021 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Docs Affects documentation Area: Xarray Pertains to xarray integration Type: Enhancement Enhancement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants