Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code scanning #1934

Merged
merged 5 commits into from Jun 24, 2021
Merged

Code scanning #1934

merged 5 commits into from Jun 24, 2021

Conversation

dopplershift
Copy link
Member

@dopplershift dopplershift commented Jun 23, 2021 •
edited

Description Of Changes

  • Finally fix the CodeQL config to skip our METAR parser (generated code)
  • Regenerate metar_parser.py from Canopy main (and rename PEG file to metar_parser.peg to match and more easily generate); also rerun pyupdater on it so that it's clean for Python 3.
  • Fix a couple LGTM minor, but real issues
  • Tweak GHA workflow so CodeQL only runs on PRs with code changes
  • Clean up a variety of minor issues suggested by CodeQL

Checklist

@dopplershift dopplershift added Area: Infrastructure Pertains to project infrastructure (e.g. CI, linting) Type: Bug Something is not working like it should labels Jun 23, 2021
@dopplershift dopplershift added the Type: Maintenance Updates and clean ups (but not wrong) label Jun 23, 2021
@lgtm-com
Copy link

lgtm-com bot commented Jun 23, 2021

This pull request fixes 2 alerts when merging d6ddac6 into d3f8a83 - view on LGTM.com

fixed alerts:

  • 1 for Module is imported with 'import' and 'import from'
  • 1 for Non-standard exception raised in special method

@dopplershift dopplershift changed the title Fix code scanning exclude for the METAR parser Code scanning Jun 23, 2021
@Unidata Unidata deleted a comment from lgtm-com bot Jun 23, 2021
@dopplershift
CI: Don't run CodeQL analysis on non-code changes
62e2514
@dopplershift
MNT: Clean up some LGTM alerts
0dea74f
@dopplershift
MNT: Regenerate METAR parser from latest canopy
1db3f51 
Canopy main@97f5790, run through pyupgrader to make pure Python 3 code.
Also went ahead and renamed the PEG file so the name of the generated module
matches what we have in the tree.
@dopplershift
MNT: Move METAR PEG parser to private subdirectory
de081c5 
This allows us to ignore it in CodeQL scanning.
@dopplershift
MNT: Clean up various issues found by CodeQL
6eb75bb 
Including a big commented out test for a solar_irradiance function we
haven't had since the early days.
@dcamron dcamron enabled auto-merge June 24, 2021 23:36
@dcamron dcamron merged commit 0fc929f into Unidata:main Jun 24, 2021
@github-actions github-actions bot added this to the 1.1.0 milestone Jun 24, 2021
@dopplershift dopplershift deleted the scanning branch June 25, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcamron dcamron dcamron approved these changes

Assignees
No one assigned
Labels
Area: Infrastructure Pertains to project infrastructure (e.g. CI, linting) Type: Bug Something is not working like it should Type: Maintenance Updates and clean ups (but not wrong)
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Clean up CodeQL config
2 participants
@dopplershift @dcamron