-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codespell #1939
Codespell #1939
Conversation
I have a commit for "pres" -> "press", but I'm not sure I actually want to make that change. "thta" -> "theta" corrects a weird and unnecessary move away from a word. "pres" vs. "press" is just a different length of abbreviation. |
I would say stay with "pres" unless we wanted to go to the full name of pressure. I wouldn't intuitively think to use "press". |
Would just going to |
So changing "pres" to "pressure" only resulted in one new line wrap, so I went ahead and did that. More importantly, I figured out how to exclude a few false alarms (involves adding the entire content of the line to a file), but this allows us to have "pres" and "thta" as checked words, and only exclude a couple of known ok occurrences--so I'm much more interested in having them changed in that case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Catches things pretty smoothly! Fan of this, and looks good to go. Just a comment line copied in the workflow.
Also work around a couple (reasonable) false alarms.
This leaves alone the API change notice, so we can't remove the ignore for "thta".
This allows us to exclude specific entire lines (by full line content) from flagging errors. This allows us to eliminate the few remaining occurrences of "pres" and "thta" that should remain, but flag any new occurrences.
I'm always a fan of adding tools that when I run them, they catch a bunch of stuff I would have liked to notice during code review. |
Description Of Changes
Checklist