Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adjacent points in sounding to have the same pressure #2089

Merged
merged 1 commit into from
Sep 14, 2021

Conversation

sgdecker
Copy link
Contributor

@sgdecker sgdecker commented Sep 8, 2021

This commit relaxes the monotonicity check that had been performed, as
real data has a tendency to repeat pressures, especially in the stratosphere.

Closes #2077

@sgdecker sgdecker requested a review from a team as a code owner September 8, 2021 20:25
@dopplershift
Copy link
Member

If you can do a git rebase main after syncing things this should pass.

@dopplershift dopplershift added Area: Calc Pertains to calculations Type: Bug Something is not working like it should labels Sep 14, 2021
@dopplershift dopplershift added this to the 1.2.0 milestone Sep 14, 2021
This commit relaxes the monotonicity check that had been performed, as
real data has a tendency to repeat pressures, especially in the stratosphere.

Closes Unidata#2077
@dopplershift dopplershift merged commit 0dd9471 into Unidata:main Sep 14, 2021
@mvoss-wx
Copy link

Hi, A couple newbie questions here.

  • For non regular git/python users, will this fix be incorporated in next Metpy1.X release?
  • This seems like a general fix for sounding data, will this also fix the more specific case of the same error that generates from the prof = mpcalc.parcel_profile function? (still not sure how a function can create a bad profile)
    thanks

@dopplershift
Copy link
Member

This fix will be in the next release, 1.2.

parcel_profile generates a profile for all the pressures given (without needing to check those pressures), so it's "bad" due to the original pressures given (from the data).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Calc Pertains to calculations Type: Bug Something is not working like it should
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pressure does not decrease monotonically in your sounding.
3 participants