Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize testing version comparison #3271

Merged
merged 15 commits into from
Nov 14, 2023
Merged

Generalize testing version comparison #3271

merged 15 commits into from
Nov 14, 2023

Commits on Nov 14, 2023

  1. Generalize version comparison

    @dcamron
    dcamron committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    4f8e317 View commit details
    Browse the repository at this point in the history

  2. Add xfail condition for old pint

    @dcamron
    dcamron committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    9d2d3f9 View commit details
    Browse the repository at this point in the history

  3. Lint

    @dcamron
    dcamron committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    4fcccfe View commit details
    Browse the repository at this point in the history

  4. Fail tests on xpass

    @dcamron
    dcamron committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    bdf9c91 View commit details
    Browse the repository at this point in the history

  5. Update test value

    @dcamron
    dcamron committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    0dc554d View commit details
    Browse the repository at this point in the history

  6. Refactor to parse version spec 

    Simplify one more time down to a single version comparison helper that
parses a package spec string and compares that spec to the currently
installed package.
    @dcamron
    dcamron committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    1c6e006 View commit details
    Browse the repository at this point in the history

  7. Add minimum required validator 

    Add validation to requested package spec to fail if the spec is out of
date and irrelevant according to package metadata.
    @dcamron
    dcamron committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    e6d77c8 View commit details
    Browse the repository at this point in the history

  8. Fix order

    @dcamron
    dcamron committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    d74e3bc View commit details
    Browse the repository at this point in the history

  9. Limit xfail to appropriate scipy

    @dcamron
    dcamron committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    4c3ccb3 View commit details
    Browse the repository at this point in the history

  10. Use operator in comparison dict

    @dcamron
    dcamron committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    9a3d77b View commit details
    Browse the repository at this point in the history

  11. Shorten name

    @dcamron
    dcamron committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    fe62928 View commit details
    Browse the repository at this point in the history

  12. Add values to error messages

    @dcamron
    dcamron committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    ab3fb4c View commit details
    Browse the repository at this point in the history

  13. Fix indent

    @dcamron
    dcamron committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    3ec60ca View commit details
    Browse the repository at this point in the history

  14. Use correct and 

    Co-authored-by: Ryan May <rmay31@gmail.com>
    @dcamron @dopplershift
    dcamron and dopplershift committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    df0db34 View commit details
    Browse the repository at this point in the history

  15. Shrink dict lines

    @dcamron
    dcamron committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    0fe46ed View commit details
    Browse the repository at this point in the history