Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return heat_index with temperature units #3307

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

rwalton91
Copy link
Contributor

Description Of Changes

This pull request updates the heat_index calculation to return the same units as the temperature used in the calculation. This change ensures parity across similar equations like wind_chill and apparent_temperature where the return value has the same units as the input temperature.

Checklist

@rwalton91 rwalton91 requested a review from a team as a code owner December 7, 2023 17:27
@rwalton91 rwalton91 requested review from dcamron and removed request for a team December 7, 2023 17:27
@CLAassistant
Copy link

CLAassistant commented Dec 7, 2023

CLA assistant check
All committers have signed the CLA.

@rwalton91 rwalton91 force-pushed the heat-index-issue-3299 branch 2 times, most recently from 94467be to 6ca06fb Compare December 7, 2023 17:38
Copy link
Member

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the changes look good, just a minor question about placement.

src/metpy/calc/basic.py Outdated Show resolved Hide resolved
@dopplershift dopplershift added Type: Enhancement Enhancement to existing functionality Area: Calc Pertains to calculations labels Dec 7, 2023
@dopplershift dopplershift added this to the November 2023 milestone Dec 7, 2023
@dopplershift dopplershift merged commit 0f71eea into Unidata:main Dec 11, 2023
34 checks passed
@dopplershift
Copy link
Member

Thanks for the contribution! 🎉 Hope to see you around in the future!

@rwalton91 rwalton91 deleted the heat-index-issue-3299 branch December 12, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Calc Pertains to calculations Type: Enhancement Enhancement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

heat_index does not return same units as temperature
3 participants