Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve isentropic interpolation #3324

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Improve isentropic interpolation #3324

merged 2 commits into from
Dec 15, 2023

Commits on Dec 14, 2023

  1. ENH: Allow 3D pressure input for isentropic_interpolation 

    Internally we were already using 3D pressure, so just avoid needless
broadcasting outside the 1D pressure case. This paves the way for direct
interpolation from e.g. sigma coords. See Unidata#3315.
    @dopplershift
    dopplershift committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    a3f7c9b View commit details
    Browse the repository at this point in the history

  2. BUG: Correct vertical coordinate assumption (Fixes Unidata#3315) 

    isentropic_interpolation_as_dataset was blindly assuming that the
vertical coordinate was pressure, resulting in a confusing unit error
when calling isentropic_interpolation. Check the dimensionality and
raise a clearer ValueError when this is not the case. Also allow users
to manually pass (as a keyword) an appropriate pressure array to use instead.
    @dopplershift
    dopplershift committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    b076471 View commit details
    Browse the repository at this point in the history