Increase minimum setuptools version to v61 #3394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`setuptools>=v61.0.0` is required for PEP 621 support (storing project metadata in pyproject.toml): https://setuptools.pypa.io/en/stable/history.html#v61-0-0
|
|
|
Have definitely thought about this in the past, but was too lazy to put in a PR. Thanks! |
dopplershift
approved these changes
Feb 13, 2024
dopplershift
added
Area: Infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
MetPy stores project metadata in pyproject.toml following PEP 621. It uses
setuptoolsas the build backend. Setuptools added support for PEP 621 in v61.0.0: https://setuptools.pypa.io/en/stable/history.html#v61-0-0However,
pyproject.tomlonly mandatessetuptools>=42. In practice I doubt it is really a problem, as the most recent version of setuptools is usually pulled in automatically when building metpy, although it is possible to contrive a problematic scenario by installing an older version of setuptools (setuptools==60, e.g.) and usingpip install's--no-build-isolationoption.Anyway, it is trivial to fix the issue, so there is little reason not to IMHO.
Checklist
[ ] Closes #xxxx[ ] Tests added[ ] Fully documented