Most unstable parcel #473
Merged
Most unstable parcel #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrleeman
force-pushed
the
Most_Unstable_Parcel
branch
2 times, most recently
from
9b8411c
to
8cba6bd
Compare
dopplershift
added
Area: Calc
|
|
Ok - on second thought I don't know about the index. It's really the index of the LAYER which could be an interpolated thing. Therefore I think just returning the height will be the most straight forward. |
|
Could we return the index only? Then the user can decide what they want to do with that information. Or I suppose returning the index could be its own function.... |
|
Could also only return the height if the height was given.... |
metpy/calc/thermo.py
Outdated
| theta_e = equivalent_potential_temperature(p_layer, T_layer) | ||
| max_idx = np.argmax(theta_e) | ||
| if heights is not None: | ||
| mu_height = heights[max_idx] |
There was a problem hiding this comment.
Is this actually correct if the layer doesn't start at the bottom?
There was a problem hiding this comment.
Nope.... hmm. Then it's back to the infamous get_layer
|
I see what you mean about the index being confusing given the layer specification--fine, no returning index. |
jrleeman
force-pushed
the
Most_Unstable_Parcel
branch
from
e7ad475
to
31ecb6b
Compare
dopplershift
approved these changes
Jul 3, 2017
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculates the most unstable parcel (pressure, temperature, dew point) by maximizing theta-e.