Floating comparisons #497
Merged
Floating comparisons #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrleeman
force-pushed
the
FloatingComparisons
branch
from
3ecf9aa
to
67230b1
Compare
dopplershift
requested changes
Jul 16, 2017
metpy/calc/tools.py
Outdated
| r"""Compare values for greater or close to boolean masks. | ||
|
|
||
| Returns a boolean mask for values greater than or equal to a target within a specified | ||
| absolute or relative tolerance (as in np.isclose). |
There was a problem hiding this comment.
How about :func:\numpy.isclose`` so we can get cross doc linking to work?
metpy/calc/tools.py
Outdated
| r"""Compare values for less or close to boolean masks. | ||
|
|
||
| Returns a boolean mask for values less than or equal to a target within a specified | ||
| absolute or relative tolerance (as in np.isclose). |
There were edge cases where greater/less than or equal to would suffer from precision issues and drop an extra point in the sounding. Modify them to use our approximate comparisons.
The initial way this bug was found was by not convering the output of parcel_profile in the test. It is removed now and tests that those comparisons are working.
jrleeman
force-pushed
the
FloatingComparisons
branch
from
67230b1
to
b836862
Compare
dopplershift
approved these changes
Jul 16, 2017
dopplershift
added
Area: Calc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds functions to compare floating point values in a greater/less than or near to sense. I also removed the conversion in the CAPE/CIN test that helped @tjwixtrom find the bug initially. Closes #488