Fix infinite loop in dp_pgrb subroutine #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the grid is nearly identical, raising the qdif value to increasing powers of 2 overflows before the do-loop can be terminate. This PR fixes Unidata#45 by using TINY() to prevent the overflow.
akrherz
force-pushed
the
fix_inf_loop
branch
from
ddea8c1
to
7ea7706
Compare
|
@sgdecker I have rebased this to get CI's opinion. Are you still happy with this change? |
|
Yes, I think it is still good. |
akrherz
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the grid is nearly identical, raising the qdif value to
increasing powers of 2 overflows before the do-loop can be
terminate. This PR fixes #45 by using TINY() to prevent the overflow.