Cleanup up some functions in preparation for lazy var reads (take 2) #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DennisHeimbigner this is the same code you already reviewed. It's has just come up in the queue, there have been no new code changes. |
DennisHeimbigner
approved these changes
Aug 7, 2018
|
Evaluating now just to make sure nothing crops up, then merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1082.
Part of #489.
Part of #965.
Clean up some functions and their error handling. These changes are part of the lazy var work. Also did a whitespace cleanup of file nc4internal.c.
This PR is ready to merge. This is the second attempt after the first (#1084) got a little confused.