Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove // style comments from source code. #1210

Merged
merged 3 commits into from
Dec 12, 2018
Merged

Remove // style comments from source code. #1210

merged 3 commits into from
Dec 12, 2018

Conversation

DennisHeimbigner
Copy link
Collaborator

We need to do this periodically because they sneek in.

We need to do this periodically because they sneek in.
@t-b
Copy link
Contributor

t-b commented Nov 30, 2018

Does the codebase compile with gcc's -ansi flag? If yes, you could add that to the CI and let gcc do the complaining. See https://gcc.gnu.org/onlinedocs/gcc/C-Dialect-Options.html.

@edhartnett
Copy link
Contributor

Good idea. I have added that to my CI system for netCDF.

@WardF
Copy link
Member

WardF commented Nov 30, 2018

Same here, I'll add it to the travis CI

@WardF WardF merged commit 5a268e3 into master Dec 12, 2018
@DennisHeimbigner DennisHeimbigner deleted the fixcomments.dmh branch January 13, 2019 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants