Combined pull requests #1249
Closed
Combined pull requests #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
WardF
commented
Dec 11, 2018
WardF
commented
- Remove // style comments from source code. #1210
- Fix error report coming out of nc4info.c #1213
- Almost done separating HDF5 from libsrc4 #1230
- Completing code separation of libsrc4 and libhdf5 #1231
- adjust tests and utils for split of libsrc4 and libhdf5 #1234 (Auspicious!)
- Fix failings of nc_test/run_inmemory.sh #1240
- Make the netcdf-c library compile with gcc -ansi. #1242
- License update.wif #1243
We need to do this periodically because they sneek in.
re: issue #1207 The NC4_get_provenance is generating a spurious error message. This properly suppresses it.
…ossibility of netcdf-4 build without hdf5
re: issue #1233 Changes: 1. remove exit that was there for testing. 2. the program tst_open_mem must be netcdf-4 only. 3. fix some diff problems - Change dataset name for tst_inmemory4_create to tst_inmemory4 - Modify tst_inmemory.c to reorder the variables (somewhat major rewrite) Minor Unrelated Fixes: 1. fix comment problem in nc_provenance.h 2. Fix memory leak in tst_open_mem.c 3. fix ncdump/bindata.c to properly compile if netcdf4 is disabled. 4. minor changes to ncgen.l
Primary fixes to get -ansi to work. 1. Convert all '//' C++ style comments to /*...*/ or to use #if 0...#endif 2. It turns out that when -ansi is specified, then a number of functions no longer are defined in the header -- but they are still in the .so file.<br> The big example is strdup(). So, added code to include/ncconfig.h to define externs for those missing functions that occur in more than one place. These are enabled if !_WIN32 && __STDC__ == 1 (__STDC__ is supposed to be the equivalent compile time flag to -ansi). Note that this requires config.h (which references ncconfig.h) to be included in files where it is currently not included. Single uses will be only in the file that uses them. 3. Added mmap test for the MAP_ANONYMOUS flag to configure.ac. Apparently this is not always defined with -ansi. 4. fix some large integer constants in nc_test4/tst_atts3.c and nc_test4/tst_filterparser.c to avoid compiler complaints. 5. fix a double constant in nc_test4/tst_filterparser.c to avoid compiler complaints. [Note I suspect #4 and #5 will be a problem on big-endian machines, but we have no way to test] Misc. Changes: 1. convert more instances of _MSC_VER to _WIN32. 2. added some debugging code to include/nctestserver.h 3. added comment about libdispatch/drc.c always being compiled. 4. modify parser generation in ncgen to remove unneeded files.
…ing by default in Cmake-based builds.
…ion-Council/netcdf-c into pr-aggregation.wif
…ion-Council/netcdf-c into pr-aggregation.wif
…ion-Council/netcdf-c into pr-aggregation.wif
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.