Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread safety: step 1: cleanup #1379

Merged
merged 2 commits into from
May 2, 2019
Merged

Thread safety: step 1: cleanup #1379

merged 2 commits into from
May 2, 2019

Conversation

DennisHeimbigner
Copy link
Collaborator

re: #1373 (partial)

  • Mark some global constants be const to indicate and to make them easier to track.
  • Hide direct access to the ncrc_globalstate behind a function call.
  • Convert dispatch tables to constants (except the user defined ones)
    This has some consequences in terms of function arguments needing to be marked
    as const also.
  • Remove some no longer needed global fields
  • Aggregate all the nclog related globals in nclog.c
  • Uniformly replace nc_sizevector{0,1} with NC_coord_{zero,one}
  • Uniformly replace nc_ptrdffvector1 with NC_stride_one
  • Remove some obsolete code

re: #1373 (partial)

* Mark some global constants be const to indicate to make them easier to track.
* Hide direct access to the ncrc_globalstate behind a function call.
* Convert dispatch tables to constants (except the user defined ones)
  This has some consequences in terms of function arguments needing to be marked
  as const also.
* Remove some no longer needed global fields
* Aggregate all the globals in nclog.c
* Uniformly replace nc_sizevector{0,1} with NC_coord_{zero,one}
* Uniformly replace nc_ptrdffvector1 with NC_stride_one
* Remove some obsolete code
@WardF
Copy link
Member

WardF commented May 1, 2019

Looks good, resolving conflicts and merging when tests end. Slowly working through the list here and over on fortran.

@WardF WardF merged commit ae1b309 into master May 2, 2019
@WardF WardF deleted the threads_part1.dmh branch May 2, 2019 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants